netdev - Re: [PATCH] random32: use real rng for non-deterministic randomness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yn4t9S71LhI8W0ek@zx2c4.com>
Date:   Fri, 13 May 2022 12:07:49 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] random32: use real rng for non-deterministic randomness

Hi Dominik,

On Fri, May 13, 2022 at 08:18:53AM +0200, Dominik Brodowski wrote:
> Nice! However, wouldn't it be much better to clean up the indirection
> introduced here as well? prandom_u32() as wrapper for get_random_u32() and
> prandom_bytes() as wrapper for get_random_bytes() seems unnecessary...

Yes; we can look at tree-wide changes for 5.20. The first step in making
tree-wide changes is filling in the old function with an inline wrapper,
which then gets removed as part of the last step after all the other
patches have landed. That's a huge process, so this is just step one.

Jason