netdev - Re: [PATCH v2 bpf-next 2/2] selftests/bpf: add selftest for bpf_ct_refresh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yn+HBKbo5eoYBPzj@lore-desk>
Date:   Sat, 14 May 2022 12:40:04 +0200
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel <netfilter-devel@...r.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>
Subject: Re: [PATCH v2 bpf-next 2/2] selftests/bpf: add selftest for
 bpf_ct_refresh_timeout kfunc

> On Thu, May 12, 2022 at 9:34 AM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> >
> > Install a new ct entry in order to perform a successful lookup and
> > test bpf_ct_refresh_timeout kfunc helper.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> 
> CI is failing:
> test_bpf_nf_ct:FAIL:flush ct entries unexpected error: 32512 (errno 2)
> test_bpf_nf_ct:FAIL:create ct entry unexpected error: 32512 (errno 2)
> 
> Please follow the links from patchwork for details.

Hi Alexei,

tests failed because conntrack is not installed on the system:

2022-05-14T00:12:09.0799053Z sh: line 1: conntrack: command not found

Is it ok to just skip the test if conntrack is not installed on the system
or do you prefer to directly send netlink messages to ct in order to add a
new ct entry?

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)