netdev - [PATCH v3 2/4] can: Kconfig: change CAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 14 May 2022 23:16:48 +0900
From:   Vincent Mailhol <mailhol.vincent@...adoo.fr>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
        Max Staudt <max@...as.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        netdev@...r.kernel.org,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>
Subject: [PATCH v3 2/4] can: Kconfig: change CAN_DEV into a menuconfig

Currently, only slcan, vcan and vxcan do not depend on CAN_DEV. This
is going to change in the next patch when can_dropped_invalid_skb()
will be moved into skb.c.

In prevision to that, move CAN_DEV one rank up by making it a
menuconfig. The description of CAN_DEV is updated accordingly.

Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
---
 drivers/net/can/Kconfig | 33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index fff259247d52..9bddccfaa0c5 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -1,5 +1,22 @@
 # SPDX-License-Identifier: GPL-2.0-only
-menu "CAN Device Drivers"
+
+menuconfig CAN_DEV
+	tristate "CAN Device Drivers"
+	default y
+	help
+	  This section contains all the CAN device drivers including
+	  the virtual ones.
+
+	  Saying Y here enables the common framework for platform CAN
+	  drivers with Netlink support. This is the standard library
+	  for CAN drivers.
+
+	  To compile as a module, choose M here: the module will be
+	  called can_dev.
+
+	  If unsure, say Y.
+
+if CAN_DEV
 
 config CAN_VCAN
 	tristate "Virtual Local CAN Interface (vcan)"
@@ -48,16 +65,6 @@ config CAN_SLCAN
 	  can be changed by the 'maxdev=xx' module option. This driver can
 	  also be built as a module. If so, the module will be called slcan.
 
-config CAN_DEV
-	tristate "Platform CAN drivers with Netlink support"
-	default y
-	help
-	  Enables the common framework for platform CAN drivers with Netlink
-	  support. This is the standard library for CAN drivers.
-	  If unsure, say Y.
-
-if CAN_DEV
-
 config CAN_CALC_BITTIMING
 	bool "CAN bit-timing calculation"
 	default y
@@ -180,8 +187,6 @@ source "drivers/net/can/softing/Kconfig"
 source "drivers/net/can/spi/Kconfig"
 source "drivers/net/can/usb/Kconfig"
 
-endif
-
 config CAN_DEBUG_DEVICES
 	bool "CAN devices debugging messages"
 	help
@@ -190,4 +195,4 @@ config CAN_DEBUG_DEVICES
 	  a problem with CAN support and want to see more of what is going
 	  on.
 
-endmenu
+endif
-- 
2.35.1