lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 May 2022 21:32:07 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Kalle Valo <kvalo@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Govind Singh <govinds@...eaurora.org>, ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Bjorn Andersson <bjorn.andersson@...aro.org>, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH] ath10k: do not enforce interrupt trigger type On 13/05/2022 17:57, Kalle Valo wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> writes: > >> Interrupt line can be configured on different hardware in different way, >> even inverted. Therefore driver should not enforce specific trigger >> type - edge rising - but instead rely on Devicetree to configure it. >> >> All Qualcomm DTSI with WCN3990 define the interrupt type as level high, >> so the mismatch between DTSI and driver causes rebind issues: >> >> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind >> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind >> [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@...00000! >> [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found >> [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6 > > So you tested on WCN3990? On what firmware version? I run it on a Qualcomm RB3 board with Qualcomm SDM845 and WCN3990. However on that kernel I did not manage to WiFi actually work - regardless of that patch - so I would no count it yet as fully tested. It would be great if someone would provide some tests. I saw Steev's replies - thanks! Best regards, Krzysztof
Powered by blists - more mailing lists