netdev - Re: [PATCH net-next v3] net: dsa: realtek: rtl8366rb: Serialize indirect PHY register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220516113349.766fky6yyqadv7e5@skbuf>
Date:   Mon, 16 May 2022 14:33:49 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v3] net: dsa: realtek: rtl8366rb: Serialize
 indirect PHY register access

On Fri, May 13, 2022 at 11:36:18PM +0200, Linus Walleij wrote:
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
> 
> Lock the regmap during the whole PHY register access routines in
> rtl8366rb.
> 
> Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> Reported-by: kernel test robot <lkp@...el.com>

I don't think I would have added this tag.

> Tested-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
> ChangeLog v2->v3:
> - Explicitly target net-next
> ChangeLog v1->v2:
> - Make sure to always return a properly assigned error
>   code on the error path in rtl8366rb_phy_read()
>   found by the kernel test robot.
> 
> I have tested that this does not create any regressions,
> it makes more sense to have this applied than not. First
> it is related to the same family as the other ASICs, also
> it makes perfect logical sense to enforce serialization
> of these reads/writes.
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>