netdev - Re: [PATCHv2 ipsec] xfrm: set dst dev to blackhole_netdev instead of loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJxX6LMPUEvadqpxHU0XW71cNwKSaggPOAHQwFHxQJYoQ@mail.gmail.com>
Date:   Sun, 15 May 2022 19:28:58 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCHv2 ipsec] xfrm: set dst dev to blackhole_netdev instead of
 loopback_dev in ifdown

On Sun, May 15, 2022 at 6:37 PM Xin Long <lucien.xin@...il.com> wrote:
>
> The global blackhole_netdev has replaced pernet loopback_dev to become the
> one given to the object that holds an netdev when ifdown in many places of
> ipv4 and ipv6 since commit 8d7017fd621d ("blackhole_netdev: use
> blackhole_netdev to invalidate dst entries").
>
> Especially after commit faab39f63c1f ("net: allow out-of-order netdev
> unregistration"), it's no longer safe to use loopback_dev that may be
> freed before other netdev.
>
> This patch is to set dst dev to blackhole_netdev instead of loopback_dev
> in ifdown.
>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>