| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220516152038.39594-11-konstantin.meskhidze@huawei.com>
Date: Mon, 16 May 2022 23:20:33 +0800
From: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
To: <mic@...ikod.net>
CC: <willemdebruijn.kernel@...il.com>,
<linux-security-module@...r.kernel.org>, <netdev@...r.kernel.org>,
<netfilter-devel@...r.kernel.org>, <yusongping@...wei.com>,
<anton.sirazetdinov@...wei.com>
Subject: [PATCH v5 10/15] seltests/landlock: add tests for connect() hooks
Adds selftests for connect socket action.
The first are with no landlock restrictions:
- connect_no_restrictions_ip4;
- connect_no_restrictions_ip6;
The second ones are with mixed landlock rules:
- connect_with_restrictions_ip4;
- connect_with_restrictions_ip6;
Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
---
Changes since v3:
* Split commit.
Changes since v4:
* Adds selftests for IP6 family:
- connect_no_restrictions_ip6.
- connect_with_restrictions_ip6.
* Refactoring code with self->port, self->addr4 and
self->addr6 variables.
---
tools/testing/selftests/landlock/net_test.c | 322 ++++++++++++++++++++
1 file changed, 322 insertions(+)
diff --git a/tools/testing/selftests/landlock/net_test.c b/tools/testing/selftests/landlock/net_test.c
index 478ef2eff559..cf914d311eb3 100644
--- a/tools/testing/selftests/landlock/net_test.c
+++ b/tools/testing/selftests/landlock/net_test.c
@@ -234,4 +234,326 @@ TEST_F_FORK(socket_test, bind_with_restrictions_ip6) {
ASSERT_EQ(-1, bind(sockfd, (struct sockaddr *)&self->addr6[2], sizeof(self->addr6[2])));
ASSERT_EQ(EACCES, errno);
}
+
+TEST_F_FORK(socket_test, connect_no_restrictions_ip4) {
+
+ int sockfd, new_fd;
+ pid_t child;
+ int status;
+
+ /* Creates a server socket */
+ sockfd = create_socket(_metadata, false, false);
+ ASSERT_LE(0, sockfd);
+
+ /* Binds a socket to port[0] */
+ ASSERT_EQ(0, bind(sockfd, (struct sockaddr *)&self->addr4[0], sizeof(self->addr4[0])));
+
+ /* Makes listening socket */
+ ASSERT_EQ(0, listen(sockfd, BACKLOG));
+
+ child = fork();
+ ASSERT_LE(0, child);
+ if (child == 0) {
+ int child_sockfd;
+
+ /* Closes listening socket for the child */
+ ASSERT_EQ(0, close(sockfd));
+ /* Create a stream client socket */
+ child_sockfd = create_socket(_metadata, false, false);
+ ASSERT_LE(0, child_sockfd);
+
+ /* Makes connection to the listening socket */
+ ASSERT_EQ(0, connect(child_sockfd, (struct sockaddr *)&self->addr4[0],
+ sizeof(self->addr4[0])));
+ _exit(_metadata->passed ? EXIT_SUCCESS : EXIT_FAILURE);
+ return;
+ }
+ /* Accepts connection from the child */
+ new_fd = accept(sockfd, NULL, 0);
+ ASSERT_LE(0, new_fd);
+
+ /* Closes connection */
+ ASSERT_EQ(0, close(new_fd));
+
+ /* Closes listening socket for the parent*/
+ ASSERT_EQ(0, close(sockfd));
+
+ ASSERT_EQ(child, waitpid(child, &status, 0));
+ ASSERT_EQ(1, WIFEXITED(status));
+ ASSERT_EQ(EXIT_SUCCESS, WEXITSTATUS(status));
+}
+
+TEST_F_FORK(socket_test, connect_no_restrictions_ip6) {
+
+ int sockfd, new_fd;
+ pid_t child;
+ int status;
+
+ /* Creates a server socket */
+ sockfd = create_socket(_metadata, true, false);
+ ASSERT_LE(0, sockfd);
+
+ /* Binds a socket to port[0] */
+ ASSERT_EQ(0, bind(sockfd, (struct sockaddr *)&self->addr6[0], sizeof(self->addr6[0])));
+
+ /* Makes listening socket */
+ ASSERT_EQ(0, listen(sockfd, BACKLOG));
+
+ child = fork();
+ ASSERT_LE(0, child);
+ if (child == 0) {
+ int child_sockfd;
+
+ /* Closes listening socket for the child */
+ ASSERT_EQ(0, close(sockfd));
+ /* Create a stream client socket */
+ child_sockfd = create_socket(_metadata, true, false);
+ ASSERT_LE(0, child_sockfd);
+
+ /* Makes connection to the listening socket */
+ ASSERT_EQ(0, connect(child_sockfd, (struct sockaddr *)&self->addr6[0],
+ sizeof(self->addr6[0])));
+ _exit(_metadata->passed ? EXIT_SUCCESS : EXIT_FAILURE);
+ return;
+ }
+ /* Accepts connection from the child */
+ new_fd = accept(sockfd, NULL, 0);
+ ASSERT_LE(0, new_fd);
+
+ /* Closes connection */
+ ASSERT_EQ(0, close(new_fd));
+
+ /* Closes listening socket for the parent*/
+ ASSERT_EQ(0, close(sockfd));
+
+ ASSERT_EQ(child, waitpid(child, &status, 0));
+ ASSERT_EQ(1, WIFEXITED(status));
+ ASSERT_EQ(EXIT_SUCCESS, WEXITSTATUS(status));
+}
+
+TEST_F_FORK(socket_test, connect_with_restrictions_ip4) {
+
+ int new_fd;
+ int sockfd_1, sockfd_2;
+ pid_t child_1, child_2;
+ int status;
+
+ struct landlock_ruleset_attr ruleset_attr = {
+ .handled_access_net = LANDLOCK_ACCESS_NET_BIND_TCP |
+ LANDLOCK_ACCESS_NET_CONNECT_TCP,
+ };
+ struct landlock_net_service_attr net_service_1 = {
+ .allowed_access = LANDLOCK_ACCESS_NET_BIND_TCP |
+ LANDLOCK_ACCESS_NET_CONNECT_TCP,
+ .port = self->port[0],
+ };
+ struct landlock_net_service_attr net_service_2 = {
+ .allowed_access = LANDLOCK_ACCESS_NET_BIND_TCP,
+ .port = self->port[1],
+ };
+
+ const int ruleset_fd = landlock_create_ruleset(&ruleset_attr,
+ sizeof(ruleset_attr), 0);
+ ASSERT_LE(0, ruleset_fd);
+
+ /* Allows connect and bind operations to the port[0] socket */
+ ASSERT_EQ(0, landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_SERVICE,
+ &net_service_1, 0));
+ /* Allows connect and deny bind operations to the port[1] socket */
+ ASSERT_EQ(0, landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_SERVICE,
+ &net_service_2, 0));
+
+ /* Enforces the ruleset. */
+ enforce_ruleset(_metadata, ruleset_fd);
+
+ /* Creates a server socket 1 */
+ sockfd_1 = create_socket(_metadata, false, false);
+ ASSERT_LE(0, sockfd_1);
+
+ /* Binds the socket 1 to address with port[0] */
+ ASSERT_EQ(0, bind(sockfd_1, (struct sockaddr *)&self->addr4[0], sizeof(self->addr4[0])));
+
+ /* Makes listening socket 1 */
+ ASSERT_EQ(0, listen(sockfd_1, BACKLOG));
+
+ child_1 = fork();
+ ASSERT_LE(0, child_1);
+ if (child_1 == 0) {
+ int child_sockfd;
+
+ /* Closes listening socket for the child */
+ ASSERT_EQ(0, close(sockfd_1));
+ /* Creates a stream client socket */
+ child_sockfd = create_socket(_metadata, false, false);
+ ASSERT_LE(0, child_sockfd);
+
+ /* Makes connection to the listening socket */
+ ASSERT_EQ(0, connect(child_sockfd, (struct sockaddr *)&self->addr4[0],
+ sizeof(self->addr4[0])));
+ _exit(_metadata->passed ? EXIT_SUCCESS : EXIT_FAILURE);
+ return;
+ }
+ /* Accepts connection from the child 1 */
+ new_fd = accept(sockfd_1, NULL, 0);
+ ASSERT_LE(0, new_fd);
+
+ /* Closes connection */
+ ASSERT_EQ(0, close(new_fd));
+
+ /* Closes listening socket 1 for the parent*/
+ ASSERT_EQ(0, close(sockfd_1));
+
+ ASSERT_EQ(child_1, waitpid(child_1, &status, 0));
+ ASSERT_EQ(1, WIFEXITED(status));
+ ASSERT_EQ(EXIT_SUCCESS, WEXITSTATUS(status));
+
+ /* Creates a server socket 2 */
+ sockfd_2 = create_socket(_metadata, false, false);
+ ASSERT_LE(0, sockfd_2);
+
+ /* Binds the socket 2 to address with port[1] */
+ ASSERT_EQ(0, bind(sockfd_2, (struct sockaddr *)&self->addr4[1], sizeof(self->addr4[1])));
+
+ /* Makes listening socket 2 */
+ ASSERT_EQ(0, listen(sockfd_2, BACKLOG));
+
+ child_2 = fork();
+ ASSERT_LE(0, child_2);
+ if (child_2 == 0) {
+ int child_sockfd;
+
+ /* Closes listening socket for the child */
+ ASSERT_EQ(0, close(sockfd_2));
+ /* Creates a stream client socket */
+ child_sockfd = create_socket(_metadata, false, false);
+ ASSERT_LE(0, child_sockfd);
+
+ /* Makes connection to the listening socket */
+ ASSERT_EQ(-1, connect(child_sockfd, (struct sockaddr *)&self->addr4[1],
+ sizeof(self->addr4[1])));
+ ASSERT_EQ(EACCES, errno);
+ _exit(_metadata->passed ? EXIT_SUCCESS : EXIT_FAILURE);
+ return;
+ }
+
+ /* Closes listening socket 2 for the parent*/
+ ASSERT_EQ(0, close(sockfd_2));
+
+ ASSERT_EQ(child_2, waitpid(child_2, &status, 0));
+ ASSERT_EQ(1, WIFEXITED(status));
+ ASSERT_EQ(EXIT_SUCCESS, WEXITSTATUS(status));
+}
+
+TEST_F_FORK(socket_test, connect_with_restrictions_ip6) {
+
+ int new_fd;
+ int sockfd_1, sockfd_2;
+ pid_t child_1, child_2;
+ int status;
+
+ struct landlock_ruleset_attr ruleset_attr = {
+ .handled_access_net = LANDLOCK_ACCESS_NET_BIND_TCP |
+ LANDLOCK_ACCESS_NET_CONNECT_TCP,
+ };
+ struct landlock_net_service_attr net_service_1 = {
+ .allowed_access = LANDLOCK_ACCESS_NET_BIND_TCP |
+ LANDLOCK_ACCESS_NET_CONNECT_TCP,
+ .port = self->port[0],
+ };
+ struct landlock_net_service_attr net_service_2 = {
+ .allowed_access = LANDLOCK_ACCESS_NET_BIND_TCP,
+ .port = self->port[1],
+ };
+
+ const int ruleset_fd = landlock_create_ruleset(&ruleset_attr,
+ sizeof(ruleset_attr), 0);
+ ASSERT_LE(0, ruleset_fd);
+
+ /* Allows connect and bind operations to the port[0] socket */
+ ASSERT_EQ(0, landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_SERVICE,
+ &net_service_1, 0));
+ /* Allows connect and deny bind operations to the port[1] socket */
+ ASSERT_EQ(0, landlock_add_rule(ruleset_fd, LANDLOCK_RULE_NET_SERVICE,
+ &net_service_2, 0));
+
+ /* Enforces the ruleset. */
+ enforce_ruleset(_metadata, ruleset_fd);
+
+ /* Creates a server socket 1 */
+ sockfd_1 = create_socket(_metadata, true, false);
+ ASSERT_LE(0, sockfd_1);
+
+ /* Binds the socket 1 to address with port[0] */
+ ASSERT_EQ(0, bind(sockfd_1, (struct sockaddr *)&self->addr6[0], sizeof(self->addr6[0])));
+
+ /* Makes listening socket 1 */
+ ASSERT_EQ(0, listen(sockfd_1, BACKLOG));
+
+ child_1 = fork();
+ ASSERT_LE(0, child_1);
+ if (child_1 == 0) {
+ int child_sockfd;
+
+ /* Closes listening socket for the child */
+ ASSERT_EQ(0, close(sockfd_1));
+ /* Creates a stream client socket */
+ child_sockfd = create_socket(_metadata, true, false);
+ ASSERT_LE(0, child_sockfd);
+
+ /* Makes connection to the listening socket */
+ ASSERT_EQ(0, connect(child_sockfd, (struct sockaddr *)&self->addr6[0],
+ sizeof(self->addr6[0])));
+ _exit(_metadata->passed ? EXIT_SUCCESS : EXIT_FAILURE);
+ return;
+ }
+ /* Accepts connection from the child 1 */
+ new_fd = accept(sockfd_1, NULL, 0);
+ ASSERT_LE(0, new_fd);
+
+ /* Closes connection */
+ ASSERT_EQ(0, close(new_fd));
+
+ /* Closes listening socket 1 for the parent*/
+ ASSERT_EQ(0, close(sockfd_1));
+
+ ASSERT_EQ(child_1, waitpid(child_1, &status, 0));
+ ASSERT_EQ(1, WIFEXITED(status));
+ ASSERT_EQ(EXIT_SUCCESS, WEXITSTATUS(status));
+
+ /* Creates a server socket 2 */
+ sockfd_2 = create_socket(_metadata, true, false);
+ ASSERT_LE(0, sockfd_2);
+
+ /* Binds the socket 2 to address with port[1] */
+ ASSERT_EQ(0, bind(sockfd_2, (struct sockaddr *)&self->addr6[1], sizeof(self->addr6[1])));
+
+ /* Makes listening socket 2 */
+ ASSERT_EQ(0, listen(sockfd_2, BACKLOG));
+
+ child_2 = fork();
+ ASSERT_LE(0, child_2);
+ if (child_2 == 0) {
+ int child_sockfd;
+
+ /* Closes listening socket for the child */
+ ASSERT_EQ(0, close(sockfd_2));
+ /* Creates a stream client socket */
+ child_sockfd = create_socket(_metadata, true, false);
+ ASSERT_LE(0, child_sockfd);
+
+ /* Makes connection to the listening socket */
+ ASSERT_EQ(-1, connect(child_sockfd, (struct sockaddr *)&self->addr6[1],
+ sizeof(self->addr6[1])));
+ ASSERT_EQ(EACCES, errno);
+ _exit(_metadata->passed ? EXIT_SUCCESS : EXIT_FAILURE);
+ return;
+ }
+
+ /* Closes listening socket 2 for the parent*/
+ ASSERT_EQ(0, close(sockfd_2));
+
+ ASSERT_EQ(child_2, waitpid(child_2, &status, 0));
+ ASSERT_EQ(1, WIFEXITED(status));
+ ASSERT_EQ(EXIT_SUCCESS, WEXITSTATUS(status));
+}
TEST_HARNESS_MAIN
--
2.25.1
Powered by blists - more mailing lists