lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2022 11:56:34 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Eric Dumazet <edumazet@...gle.com> Cc: Eric Dumazet <eric.dumazet@...il.com>, "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 4/4] net: call skb_defer_free_flush() before each napi_poll() On Mon, 16 May 2022 11:26:14 -0700 Eric Dumazet wrote: > On Mon, May 16, 2022 at 11:21 AM Jakub Kicinski <kuba@...nel.org> wrote: > > > > On Sun, 15 May 2022 21:24:56 -0700 Eric Dumazet wrote: > > > -end: > > > - skb_defer_free_flush(sd); > > > +end:; > > > > Sorry for the nit pick but can I remove this and just return like we > > did before f3412b3879b4? Is there a reason such "label:;}" is good? > > I thought that having a return in the middle of this function would > hurt us at some point. I guess personal preference. Let's leave it unless someone else shares my disregard for pointlessly jumping to the closing bracket :)
Powered by blists - more mailing lists