netdev - Re: [PATCH RESEND net] bonding: fix missed rcu protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoNXJ0XGY2csweTj@Laptop-X1>
Date:   Tue, 17 May 2022 16:04:55 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...il.com>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot+92beb3d46aab498710fa@...kaller.appspotmail.com,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH RESEND net] bonding: fix missed rcu protection

On Tue, May 17, 2022 at 09:24:00AM +0200, Paolo Abeni wrote:
> On Tue, 2022-05-17 at 11:42 +0800, Hangbin Liu wrote:
> > On Mon, May 16, 2022 at 06:10:28PM -0700, Jakub Kicinski wrote:
> > > Can't ->get_ts_info sleep now? It'd be a little sad to force it 
> > > to be atomic just because of one upper dev trying to be fancy.
> > > Maybe all we need to do is to take a ref on the real_dev?
> > 
> > Do you mean
> > 
> > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> > index 38e152548126..b60450211579 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -5591,16 +5591,20 @@ static int bond_ethtool_get_ts_info(struct net_device *bond_dev,
> >  	const struct ethtool_ops *ops;
> >  	struct net_device *real_dev;
> >  	struct phy_device *phydev;
> > +	int ret = 0;
> >  
> 
> You additionally need something alike the following:
> 
> 	rcu_read_lock();

Thanks Paolo, I only thought the real_dev ref and forgot the initial problem
is the rcu warning...

Hangbin