netdev - Re: [PATCH v4 2/2] ath9k: htc: clean up statistics macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qwscvp2.fsf@toke.dk>
Date:   Tue, 17 May 2022 12:14:33 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     Pavel Skripkin <paskripkin@...il.com>, kvalo@...nel.org,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Pavel Skripkin <paskripkin@...il.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>
Subject: Re: [PATCH v4 2/2] ath9k: htc: clean up statistics macros

Pavel Skripkin <paskripkin@...il.com> writes:

> I've changed *STAT_* macros a bit in previous patch and I seems like
> they become really unreadable. Align these macros definitions to make
> code cleaner and fix folllowing checkpatch warning
>
> ERROR: Macros with complex values should be enclosed in parentheses
>
> Also, statistics macros now accept an hif_dev as argument, since
> macros that depend on having a local variable with a magic name
> don't abide by the coding style.
>
> No functional change
>
> Suggested-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> ---

This patch doesn't apply; please rebase on top of the ath-next branch in
Kalle's 'ath' tree...

-Toke