netdev - RE: [PATCH 09/12] net: mana: Move header files to a common location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR21MB3263114D9D57A3F385FCA6EBCECE9@PH7PR21MB3263.namprd21.prod.outlook.com>
Date:   Tue, 17 May 2022 19:34:21 +0000
From:   Long Li <longli@...rosoft.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Leon Romanovsky <leon@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [PATCH 09/12] net: mana: Move header files to a common location

> Subject: Re: [PATCH 09/12] net: mana: Move header files to a common location
> 
> On Tue, May 17, 2022 at 02:04:33AM -0700, longli@...uxonhyperv.com wrote:
> > From: Long Li <longli@...rosoft.com>
> >
> > In preparation to add MANA RDMA driver, move all the required header
> > files to a common location for use by both Ethernet and RDMA drivers.
> >
> > Signed-off-by: Long Li <longli@...rosoft.com>
> > ---
> >  MAINTAINERS                                                   | 1 +
> >  drivers/net/ethernet/microsoft/mana/gdma_main.c               | 2 +-
> >  drivers/net/ethernet/microsoft/mana/hw_channel.c              | 4 ++--
> >  drivers/net/ethernet/microsoft/mana/mana_bpf.c                | 2 +-
> >  drivers/net/ethernet/microsoft/mana/mana_en.c                 | 2 +-
> >  drivers/net/ethernet/microsoft/mana/mana_ethtool.c            | 2 +-
> >  drivers/net/ethernet/microsoft/mana/shm_channel.c             | 2 +-
> >  {drivers/net/ethernet/microsoft => include/linux}/mana/gdma.h | 0
> >  .../ethernet/microsoft => include/linux}/mana/hw_channel.h    | 0
> >  {drivers/net/ethernet/microsoft => include/linux}/mana/mana.h | 0
> >  .../ethernet/microsoft => include/linux}/mana/shm_channel.h   | 0
> >  11 files changed, 8 insertions(+), 7 deletions(-)  rename
> > {drivers/net/ethernet/microsoft => include/linux}/mana/gdma.h (100%)
> > rename {drivers/net/ethernet/microsoft =>
> > include/linux}/mana/hw_channel.h (100%)  rename
> > {drivers/net/ethernet/microsoft => include/linux}/mana/mana.h (100%)
> > rename {drivers/net/ethernet/microsoft =>
> > include/linux}/mana/shm_channel.h (100%)
> 
> I know mlx5 did it like this, but I wonder if include/net is more appropriate?
> 
> Or maybe include/aux/?

I can move the header files to include/net/mana, if that sounds okay and no objection to doing that.

Long

> 
> Jason