netdev - Re: [PATCH net-next] net: ifdefy the wireless pointers in struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 09:08:25 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        johannes@...solutions.net, alex.aring@...il.com,
        mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc,
        sven@...fation.org, linux-wireless@...r.kernel.org,
        linux-wpan@...r.kernel.org
Subject: Re: [PATCH net-next] net: ifdefy the wireless pointers in struct
 net_device


Hello.

On 16.05.22 23:56, Jakub Kicinski wrote:
> Most protocol-specific pointers in struct net_device are under
> a respective ifdef. Wireless is the notable exception. Since
> there's a sizable number of custom-built kernels for datacenter
> workloads which don't build wireless it seems reasonable to
> ifdefy those pointers as well.
> 
> While at it move IPv4 and IPv6 pointers up, those are special
> for obvious reasons.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: johannes@...solutions.net
> CC: alex.aring@...il.com
> CC: stefan@...enfreihafen.org
> CC: mareklindner@...mailbox.ch
> CC: sw@...onwunderlich.de
> CC: a@...table.cc
> CC: sven@...fation.org
> CC: linux-wireless@...r.kernel.org
> CC: linux-wpan@...r.kernel.org
> ---
>   include/linux/netdevice.h       | 8 ++++++--
>   include/net/cfg80211.h          | 5 +----
>   include/net/cfg802154.h         | 2 ++
>   net/batman-adv/hard-interface.c | 2 ++
>   net/wireless/core.c             | 6 ++++++
>   5 files changed, 17 insertions(+), 6 deletions(-)

For the ieee802154 changes:

Acked-by: Stefan Schmidt <stefan@...enfreihafen.org>

regards
Stefan Schmidt