netdev - Re: [PATCH v2 net-next 04/15] net: ethernet: mtk_eth_soc: add txd_size to mtk_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YoSufPWnGPdtVYZ+@lore-desk>
Date:   Wed, 18 May 2022 10:29:48 +0200
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, nbd@....name, john@...ozen.org,
        sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        Sam.Shih@...iatek.com, linux-mediatek@...ts.infradead.org,
        devicetree@...r.kernel.org, robh@...nel.org,
        lorenzo.bianconi@...hat.com
Subject: Re: [PATCH v2 net-next 04/15] net: ethernet: mtk_eth_soc: add
 txd_size to mtk_soc_data

> On Mon, 16 May 2022 18:06:31 +0200 Lorenzo Bianconi wrote:
> >  	eth->scratch_ring = dma_alloc_coherent(eth->dma_dev,
> > -					       cnt * sizeof(struct mtk_tx_dma),
> > +					       cnt * soc->txrx.txd_size,
> >  					       &eth->phy_scratch_ring,
> >  					       GFP_ATOMIC);
> >  	if (unlikely(!eth->scratch_ring))
> >  		return -ENOMEM;
> >  
> > -	eth->scratch_head = kcalloc(cnt, MTK_QDMA_PAGE_SIZE,
> > -				    GFP_KERNEL);
> > +	eth->scratch_head = kcalloc(cnt, MTK_QDMA_PAGE_SIZE, GFP_KERNEL);
> 
> Unrelated, but GFP_ATOMIC right next to GFP_KERNEL caught my attention.

ack, mtk_init_fq_dma() is run by mtk_open() so it is ok to use GFP_KERNEL. I
will fix it in v3.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)