netdev - Re: [PATCH net-next v2] net: ifdefy the wireless pointers in struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220518122940.6f4da4a8@kernel.org>
Date:   Wed, 18 May 2022 12:29:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, Stefan Schmidt <stefan@...enfreihafen.org>,
        alex.aring@...il.com, mareklindner@...mailbox.ch,
        sw@...onwunderlich.de, a@...table.cc, sven@...fation.org,
        linux-wireless@...r.kernel.org, linux-wpan@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: ifdefy the wireless pointers in struct
 net_device

On Wed, 18 May 2022 20:59:21 +0200 Johannes Berg wrote:
> Acked-by: Johannes Berg <johannes@...solutions.net>

Thanks!

> Do you want me to follow up with trying to union the pointer into
> ml_priv?
> 
> I prefer to union it rather than use ml_priv because we'll not want to
> use the getter everywhere when we already know, only on the boundaries.

Your call. Replacing all the direct references with a helper call could
indeed be onerous.