netdev - Re: [PATCH net-next] show rx_otherhost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220518130002.0a1bf327@hermes.local>
Date:   Wed, 18 May 2022 13:00:02 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jeffrey Ji <jeffreyjilinux@...il.com>
Cc:     Ido Schimmel <idosch@...sch.org>, David Ahern <dsahern@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Brian Vazquez <brianvv@...gle.com>, netdev@...r.kernel.org,
        Jeffrey Ji <jeffreyji@...gle.com>
Subject: Re: [PATCH net-next] show rx_otherhost_dropped stat in ip link show

On Wed, 18 May 2022 07:29:08 -1000
Jeffrey Ji <jeffreyjilinux@...il.com> wrote:

> > >               /* RX stats */
> > > -             fprintf(fp, "    RX: %*s %*s %*s %*s %*s %*s %*s%s",
> > > +             fprintf(fp, "    RX: %*s %*s %*s %*s %*s %*s %*s%*s%s",
> > >                       cols[0] - 4, "bytes", cols[1], "packets",
> > >                       cols[2], "errors", cols[3], "dropped",
> > >                       cols[4], "missed", cols[5], "mcast",
> > > -                     cols[6], s->rx_compressed ? "compressed" : "", _SL_);
> > > +                     s->rx_compressed ? cols[6] : 0,
> > > +                     s->rx_compressed ? "compressed " : "",
> > > +                     s->rx_otherhost_dropped ? cols[7] : 0,
> > > +                     s->rx_otherhost_dropped ? "otherhost_dropped" : "",

This belongs in the detail part not in the common stats.

Look where nohandler etc errors are.