netdev - Re: [PATCH net v2] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18852332-ee42-ef7e-67a3-bbd91a6694ba@quicinc.com>
Date:   Thu, 19 May 2022 08:48:44 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     <duoming@....edu.cn>, Kalle Valo <kvalo@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <amitkarwar@...il.com>,
        <ganapathi017@...il.com>, <sharvari.harisangam@....com>,
        <huxinming820@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] net: wireless: marvell: mwifiex: fix sleep in
 atomic context bugs

On 5/19/2022 8:14 AM, duoming@....edu.cn wrote:
> Hello,
> 
> On Thu, 19 May 2022 17:58:47 +0300 Kalle Valo wrote:
> 
>>> There are sleep in atomic context bugs when uploading device dump
>>> data on usb interface. The root cause is that the operations that
>>> may sleep are called in fw_dump_timer_fn which is a timer handler.
>>> The call tree shows the execution paths that could lead to bugs:
>>>
>>>     (Interrupt context)
>>> fw_dump_timer_fn
>>>    mwifiex_upload_device_dump
>>>      dev_coredumpv(..., GFP_KERNEL)

just looking at this description, why isn't the simple fix just to 
change this call to use GFP_ATOMIC?