netdev - Re: regression: 'ctnetlink_dump_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 May 2022 13:13:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     Florian Westphal <fw@...len.de>, Oliver Smith <osmith@...mocom.de>,
        netdev@...r.kernel.org, Harald Welte <laforge@...monks.org>
Subject: Re: regression: 'ctnetlink_dump_one_entry' defined but not used

On Thu, 19 May 2022 12:21:00 +0200 Florian Westphal wrote:
> Oliver Smith <osmith@...mocom.de> wrote:
> > Hi Florian,
> > 
> > since May 17 we see some automatic builds against net-next.git fail with:
> >   
> > > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > >  1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > >       |            ^~~~~~~~~~~~~~~~~~~~~~~~  
> > 
> > Looks like this is a regression from your patch 8a75a2c17, I guess
> > ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?  
> 
> Its fixed in nf-next.

Let's get it out to net-next, please, I'm carrying this patch locally
as well :(