netdev - Re: [PATCH bpf-next v9 0/5] New BPF helpers to accelerate synproxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 May 2022 21:42:12 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Maxim Mikityanskiy <maximmi@...dia.com>,
        Ilya Leoshkevich <iii@...ux.ibm.com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Networking <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Joe Stringer <joe@...ium.io>,
        Florent Revest <revest@...omium.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Florian Westphal <fw@...len.de>, pabeni@...hat.com
Subject: Re: [PATCH bpf-next v9 0/5] New BPF helpers to accelerate synproxy

On Wed, May 18, 2022 at 6:43 AM Maxim Mikityanskiy <maximmi@...dia.com> wrote:
>
> On 2022-05-16 20:17, Maxim Mikityanskiy wrote:
> > On 2022-05-11 14:48, Maxim Mikityanskiy wrote:
> >> On 2022-05-11 02:59, Andrii Nakryiko wrote:
> >>> On Tue, May 10, 2022 at 12:21 PM Maxim Mikityanskiy
> >>> <maximmi@...dia.com> wrote:
> >>>>
> >>>> On 2022-05-07 00:51, Andrii Nakryiko wrote:
> >>>>>
> >>>>> Is it expected that your selftests will fail on s390x? Please check
> >>>>> [0]
> >>>>
> >>>> I see it fails with:
> >>>>
> >>>> test_synproxy:FAIL:ethtool -K tmp0 tx off unexpected error: 32512
> >>>> (errno 2)
> >>>>
> >>>> errno 2 is ENOENT, probably the ethtool binary is missing from the
> >>>> s390x
> >>>> image? When reviewing v6, you said you added ethtool to the CI image.
> >>>> Maybe it was added to x86_64 only? Could you add it to s390x?
> >>>>
> >>>
> >>> Could be that it was outdated in s390x, but with [0] just merged in it
> >>> should have pretty recent one.
> >>
> >> Do you mean the image was outdated and didn't contain ethtool? Or
> >> ethtool was in the image, but was outdated? If the latter, I would
> >> expect it to work, this specific ethtool command has worked for ages.
> >
> > Hi Andrii,
> >
> > Could you reply this question? I need to understand whether I need to
> > make any changes to the CI before resubmitting.
>
> I brought up a s390x VM to run the test locally, and there are two
> issues with the latest (2022-05-09) s390x image:
>
> 1. It lacks stdbuf. stdbuf is used by
> tools/testing/selftests/bpf/vmtest.sh to run any test, and this is
> clearly broken. Hence two questions:
>
> 1.1. How does CI work without stdbuf in the image? I thought it used the
> same vmtest.sh script, is that right?

no, CI doesn't use vmtest.sh. vmtest.sh is an approximation of what CI
is doing, but it doesn't share the code/scripts (it does use the same
kernel config and VM image, though)

>
> 1.2. Who can add stdbuf to the image (to fix local runs)?
>

For s390x things I usually ping Ilya. Ilya, can you help here please?

> 2. It lacks iptables needed by my test, so if I resubmit my series, it
> will fail on the CI again. Who can add iptables to the image?

Ditto, I'll defer to Ilya for this.

>
> I also compared the old (2021-03-24) and the new (2022-05-09) s390x
> images, and ethtool was indeed added only after my submission, so that
> explains the current CI error.
>
> > Thanks,
> > Max
>