netdev - regression: 'ctnetlink_dump_one_entry' defined but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <97b1ea34-250b-48ba-bc04-321b6c0482c1@sysmocom.de>
Date:   Thu, 19 May 2022 11:06:31 +0200
From:   Oliver Smith <osmith@...mocom.de>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org, Harald Welte <laforge@...monks.org>
Subject: regression: 'ctnetlink_dump_one_entry' defined but not used

Hi Florian,

since May 17 we see some automatic builds against net-next.git fail with:

> net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
>  1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~

Looks like this is a regression from your patch 8a75a2c17, I guess 
ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?

Best,
Oliver
-- 
- Oliver Smith <osmith@...mocom.de>            https://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte