netdev - Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3_4fNQV51V0-QUnuTr4dK0-S_ffeFzfA8vG1uGh8vyhg@mail.gmail.com>
Date:   Fri, 20 May 2022 13:30:50 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, corbet@....net, tsbogend@...ha.franken.de,
        mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        sburla@...vell.com, vburru@...vell.com, aayarekar@...vell.com,
        arnd@...db.de, zhangyue1@...inos.cn, linux-doc@...r.kernel.org,
        linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-parisc@...r.kernel.org
Subject: Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip &
 DIGITAL EtherWORKS PCI/EISA

On Thu, May 19, 2022 at 4:13 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Looks like almost all changes to this driver had been tree-wide
> refactoring since git era begun. There is one commit from Al
> 15 years ago which could potentially be fixing a real bug.
>
> The driver is using virt_to_bus() and is a real magnet for pointless
> cleanups. It seems unlikely to have real users. Let's try to shed
> this maintenance burden.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: corbet@....net
> CC: tsbogend@...ha.franken.de
> CC: mpe@...erman.id.au
> CC: benh@...nel.crashing.org
> CC: paulus@...ba.org
> CC: sburla@...vell.com
> CC: vburru@...vell.com
> CC: aayarekar@...vell.com
> CC: arnd@...db.de

Acked-by: Arnd Bergmann <arnd@...db.de>

> ---
>  .../device_drivers/ethernet/dec/de4x5.rst     |  189 -
>  .../device_drivers/ethernet/index.rst         |    1 -
>  arch/mips/configs/mtx1_defconfig              |    1 -
>  arch/powerpc/configs/chrp32_defconfig         |    1 -
>  arch/powerpc/configs/ppc6xx_defconfig         |    1 -
>  drivers/net/ethernet/dec/tulip/Kconfig        |   15 -
>  drivers/net/ethernet/dec/tulip/Makefile       |    1 -
>  drivers/net/ethernet/dec/tulip/de4x5.c        | 5591 -----------------
>  drivers/net/ethernet/dec/tulip/de4x5.h        | 1017 ---


I checked the defconfig files to make sure we are not removing the
last ethernet driver from
one of them. mtx1 has built-in networking and no PCI slot, so this is
definitely fine.
the ppc32 configs are for machines with PCI slots and also enable
multiple drivers but I saw
nothing specifically needing this card.

       Arnd