netdev - Re: [PATCH net-next 1/1] net: wwan: t7xx: Add port for modem logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220520103711.5f7f5b45@kernel.org>
Date:   Fri, 20 May 2022 10:37:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Moises Veleta <moises.veleta@...ux.intel.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        johannes@...solutions.net, ryazanov.s.a@...il.com,
        loic.poulain@...aro.org, m.chetan.kumar@...el.com,
        chandrashekar.devegowda@...el.com, linuxwwan@...el.com,
        haijun.liu@...iatek.com, andriy.shevchenko@...ux.intel.com,
        ilpo.jarvinen@...ux.intel.com, ricardo.martinez@...ux.intel.com,
        sreehari.kancharla@...el.com, dinesh.sharma@...el.com
Subject: Re: [PATCH net-next 1/1] net: wwan: t7xx: Add port for modem
 logging

On Thu, 19 May 2022 11:27:03 -0700 Moises Veleta wrote:
> +	ret = copy_from_user(skb_put(skb, actual_len), buf, actual_len);
> +	if (ret) {
> +		ret = -EFAULT;
> +		goto err_out;
> +	}
> +
> +	ret = t7xx_port_send_skb(port, skb, 0, 0);
> +	if (ret)
> +		goto err_out;

We don't allow using debugfs to pass random data from user space 
to firmware in networking. You need to find another way.