lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 May 2022 15:00:45 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Yonghong Song <yhs@...com> Cc: Feng zhou <zhoufeng.zf@...edance.com>, Shuah Khan <shuah@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>, john fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...hat.com>, Jiri Olsa <jolsa@...nel.org>, Dave Marchevsky <davemarchevsky@...com>, Joanne Koong <joannekoong@...com>, Geliang Tang <geliang.tang@...e.com>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, duanxiongchun@...edance.com, Muchun Song <songmuchun@...edance.com>, Dongdong Wang <wangdongdong.6@...edance.com>, Cong Wang <cong.wang@...edance.com>, zhouchengming@...edance.com, Yosry Ahmed <yosryahmed@...gle.com> Subject: Re: [PATCH bpf-next v2] selftests/bpf: fix some bugs in map_lookup_percpu_elem testcase On Wed, May 18, 2022 at 8:44 AM Yonghong Song <yhs@...com> wrote: > > > > On 5/17/22 7:50 PM, Feng zhou wrote: > > From: Feng Zhou <zhoufeng.zf@...edance.com> > > > > comments from Andrii Nakryiko, details in here: > > https://lore.kernel.org/lkml/20220511093854.411-1-zhoufeng.zf@bytedance.com/T/ > > > > use /* */ instead of // > > use libbpf_num_possible_cpus() instead of sysconf(_SC_NPROCESSORS_ONLN) > > use 8 bytes for value size > > fix memory leak > > use ASSERT_EQ instead of ASSERT_OK > > add bpf_loop to fetch values on each possible CPU > > > > Fixes: ed7c13776e20c74486b0939a3c1de984c5efb6aa ("selftests/bpf: add test case for bpf_map_lookup_percpu_elem") > > Signed-off-by: Feng Zhou <zhoufeng.zf@...edance.com> > > Acked-by: Yonghong Song <yhs@...com> I've fixed remaining formatting issues and added my_pid check to avoid accidental interference with other tests/processes. Applied to bpf-next, thanks.
Powered by blists - more mailing lists