netdev - Re: [PATCH net 1/2] selftests/bpf: Fix build error with ima

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzZd_BwPr3UYrF_sXT28oKHfKP-=Ws2KSHDKtSc2AK9dNw@mail.gmail.com>
Date:   Fri, 20 May 2022 15:58:30 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Networking <netdev@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Ilya Leoshkevich <iii@...ux.ibm.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH net 1/2] selftests/bpf: Fix build error with ima_setup.sh

On Wed, May 18, 2022 at 7:44 PM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Wed, May 18, 2022 at 03:36:53PM -0700, Andrii Nakryiko wrote:
> > > On Fri, May 13, 2022 at 02:58:05PM -0700, Andrii Nakryiko wrote:
> > > > > -TRUNNER_EXTRA_FILES := $(OUTPUT)/urandom_read $(OUTPUT)/bpf_testmod.ko \
> > > > > -                      ima_setup.sh                                     \
> > > > > +TRUNNER_EXTRA_BUILD := $(OUTPUT)/urandom_read $(OUTPUT)/bpf_testmod.ko \
> > > > >                        $(wildcard progs/btf_dump_test_case_*.c)
> > > >
> > > >
> > > > note that progs/btf_dump_test_case_*.c are not built, they are just
> > > > copied over (C source files), so I don't think this fix is necessary.
> > > >
> > > > btw, I tried running `OUTPUT="/tmp/bpf" make test_progs` and it didn't
> > > > error out. But tbh, I'd recommend building everything instead of
> > > > building individual targets.
> > >
> > > After update the code to latest bpf-next. It works this time, the ima_setup.sh
> > > was copied to target folder correctly.
> > >
> > >   EXT-COPY [test_progs] urandom_read bpf_testmod.ko liburandom_read.so ima_setup.sh btf_dump_test_case_bitfields.c btf_dump_test_case_multidim.c btf_dump_test_case_namespacing.c btf_dump_test_case_ordering.c btf_dump_test_case_packing.c btf_dump_test_case_padding.c btf_dump_test_case_syntax.c
> > >   BINARY   test_progs
> > >
> > > Not sure why the previous kernel doesn't work. But anyway I will drop this patch.
> > >
> > > On the other hand, when I build with latest bpf-next. I got error like:
> > >
> > > """
> > > # OUTPUT="/tmp/bpf" make test_progs
> > >   BINARY   urandom_read                                                                                                                                                       gcc -g -O0 -rdynamic -Wall -Werror -DHAVE_GENHDR  -I/home/net/tools/testing/selftests/bpf -I/tmp/bpf/tools/include -I/home/net/include/generated -I/home/net/tools/lib -I/home/net/tools/include -I/home/net/tools/include/uapi -I/tmp/bpf  urandom_read.c urandom_read_aux.c  \
> > >           liburandom_read.so -lelf -lz -lrt -lpthread   \
> > >           -Wl,-rpath=. -Wl,--build-id=sha1 -o /tmp/bpf/urandom_read
> >
> > we assume liburandom_read.so is going to be under selftests/bpf here,
> > but it's actually under $(OUTPUT)/
> >
> > Can you try $(OUTPUT)/liburandom_read.so? I suspect this might break
> > -rpath=., though, but let's try this first?
>
> Sigh.. After rebase to latest bpf-next, to make clean and re-do
> `OUTPUT="/tmp/bpf" make test_progs`, There is no liburandom_read.so build
> issue but the ima_setup.sh error come up again...
>
>   LINK     resolve_btfids
>   LIB      liburandom_read.so
>   BINARY   urandom_read
>   MOD      bpf_testmod.ko
>   CC [M]  /home/net/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.o
>   MODPOST /home/net/tools/testing/selftests/bpf/bpf_testmod/Module.symvers
>   CC [M]  /home/net/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.mod.o
>   LD [M]  /home/net/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.ko
>   BTF [M] /home/net/tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.ko
> make: *** No rule to make target '/tmp/bpf/ima_setup.sh', needed by 'ima_setup.sh'.  Stop.
>
> Not sure if it's a build environment setup issue or others.

I don't use OUTPUT when building selftests and see no issues, so this
must be related. If you care about OUTPUT working please try to debug
and figure this out.

>
> Hangbin