netdev - Re: [PATCH net-next] net: avoid strange behavior with skb_defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165309241162.18678.15841559913999276688.git-patchwork-notify@kernel.org>
Date:   Sat, 21 May 2022 00:20:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     edumazet@...gle.com, netdev@...r.kernel.org, pabeni@...hat.com,
        davem@...emloft.net
Subject: Re: [PATCH net-next] net: avoid strange behavior with skb_defer_max == 1

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 18 May 2022 11:55:22 -0700 you wrote:
> When user sets skb_defer_max to 1 the kick threshold is 0
> (half of 1). If we increment queue length before the check
> the kick will never happen, and the skb may get stranded.
> This is likely harmless but can be avoided by moving the
> increment after the check. This way skb_defer_max == 1
> will always kick. Still a silly config to have, but
> somehow that feels more correct.
> 
> [...]

Here is the summary with links:
  - [net-next] net: avoid strange behavior with skb_defer_max == 1
    https://git.kernel.org/netdev/net-next/c/c09b0cd2cc6c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html