| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220523165609.GA1743214-robh@kernel.org>
Date: Mon, 23 May 2022 11:56:09 -0500
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: devicetree@...r.kernel.org,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Sam Ravnborg <sam@...nborg.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Benson Leung <bleung@...omium.org>,
Guenter Roeck <groeck@...omium.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Peter Rosin <peda@...ntia.se>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Kalle Valo <kvalo@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Sebastian Reichel <sre@...nel.org>,
Matt Mackall <mpm@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mark Brown <broonie@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
dri-devel@...ts.freedesktop.org, linux-gpio@...r.kernel.org,
linux-input@...r.kernel.org, chrome-platform@...ts.linux.dev,
linux-media@...r.kernel.org, netdev@...r.kernel.org,
linux-pci@...r.kernel.org, linux-pm@...r.kernel.org,
linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-serial@...r.kernel.org, alsa-devel@...a-project.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix properties without any type
On Sat, May 21, 2022 at 05:03:41PM +0200, Krzysztof Kozlowski wrote:
> On 19/05/2022 23:14, Rob Herring wrote:
> > Now that the schema tools can extract type information for all
> > properties (in order to decode dtb files), finding properties missing
> > any type definition is fairly trivial though not yet automated.
> >
> > Fix the various property schemas which are missing a type. Most of these
> > tend to be device specific properties which don't have a vendor prefix.
> > A vendor prefix is how we normally ensure a type is defined.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> > .../arm/hisilicon/controller/hip04-bootwrapper.yaml | 5 +++--
> > .../bindings/display/bridge/toshiba,tc358768.yaml | 1 +
> > .../devicetree/bindings/display/panel/panel-timing.yaml | 5 +++++
> > .../bindings/display/panel/raydium,rm67191.yaml | 1 +
> > .../bindings/display/panel/samsung,s6e8aa0.yaml | 1 +
> > .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 +
> > .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 1 +
> > .../devicetree/bindings/input/matrix-keymap.yaml | 4 ++++
> > Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 3 ++-
> > Documentation/devicetree/bindings/mux/reg-mux.yaml | 8 ++++++--
> > Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> > Documentation/devicetree/bindings/net/ingenic,mac.yaml | 1 +
> > .../devicetree/bindings/net/ti,davinci-mdio.yaml | 1 +
> > .../devicetree/bindings/net/wireless/ti,wlcore.yaml | 2 ++
> > .../devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 6 ++++--
> > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++
> > .../devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml | 2 ++
> > Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml | 1 +
> > .../devicetree/bindings/power/supply/battery.yaml | 7 ++++++-
> > .../devicetree/bindings/power/supply/charger-manager.yaml | 1 +
> > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 1 +
> > Documentation/devicetree/bindings/serial/8250.yaml | 1 +
> > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++
> > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++
> > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 +
> > 25 files changed, 55 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> > index 7378159e61df..483caf0ce25b 100644
> > --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> > +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> > @@ -17,14 +17,15 @@ properties:
> > - const: hisilicon,hip04-bootwrapper
> >
> > boot-method:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > description: |
> > Address and size of boot method.
> > [0]: bootwrapper physical address
> > [1]: bootwrapper size
> > [2]: relocation physical address
> > [3]: relocation size
> > - minItems: 1
> > - maxItems: 2
> > + minItems: 2
> > + maxItems: 4
> >
> > required:
> > - compatible
> > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> > index 3bd670b8e5cd..0b6f5bef120f 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> > @@ -58,6 +58,7 @@ properties:
> >
> > properties:
> > data-lines:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [ 16, 18, 24 ]
> >
> > port@1:
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > index 7749de95ee40..229e3b36ee29 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> > @@ -146,6 +146,7 @@ properties:
> > Horizontal sync pulse.
> > 0 selects active low, 1 selects active high.
> > If omitted then it is not used by the hardware
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [0, 1]
> >
> > vsync-active:
> > @@ -153,6 +154,7 @@ properties:
> > Vertical sync pulse.
> > 0 selects active low, 1 selects active high.
> > If omitted then it is not used by the hardware
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [0, 1]
> >
> > de-active:
> > @@ -160,6 +162,7 @@ properties:
> > Data enable.
> > 0 selects active low, 1 selects active high.
> > If omitted then it is not used by the hardware
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [0, 1]
> >
> > pixelclk-active:
> > @@ -169,6 +172,7 @@ properties:
> > sample data on rising edge.
> > Use 1 to drive pixel data on rising edge and
> > sample data on falling edge
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [0, 1]
> >
> > syncclk-active:
> > @@ -179,6 +183,7 @@ properties:
> > sample sync on rising edge of pixel clock.
> > Use 1 to drive sync on rising edge and
> > sample sync on falling edge of pixel clock
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [0, 1]
> >
> > interlaced:
> > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml
> > index 745dd247c409..617aa8c8c03a 100644
> > --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml
> > @@ -24,6 +24,7 @@ properties:
> >
> > dsi-lanes:
> > description: Number of DSI lanes to be used must be <3> or <4>
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [3, 4]
> >
> > v3p3-supply:
> > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> > index ca959451557e..1cdc91b3439f 100644
> > --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> > @@ -36,6 +36,7 @@ properties:
> >
> > init-delay:
> > description: delay after initialization sequence [ms]
> > + $ref: /schemas/types.yaml#/definitions/uint32
> >
> > panel-width-mm:
> > description: physical panel width [mm]
> > diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> > index 5fe19fa5f67c..a99e7842ca17 100644
> > --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> > @@ -26,6 +26,7 @@ properties:
> > const: 2
> >
> > registers-number:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > description: Number of daisy-chained shift registers
> >
> > enable-gpios:
> > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > index e8f137abb03c..aa61fe64be63 100644
> > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > @@ -31,6 +31,7 @@ properties:
> > type: boolean
> >
> > function-row-physmap:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > minItems: 1
> > maxItems: 15
> > description: |
> > diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> > index 6699d5e32dca..9f703bb51e12 100644
> > --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> > +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> > @@ -27,6 +27,10 @@ properties:
> > column and linux key-code. The 32-bit big endian cell is packed as:
> > row << 24 | column << 16 | key-code
> >
> > + linux,no-autorepeat:
> > + type: boolean
> > + description: Disable keyrepeat
>
> This should be rather a separate patch - it's documenting a missing
> property, not only a type.
Yes, I've dropped this hunk while applying.
Rob
Powered by blists - more mailing lists