netdev - Re: [RFC PATCH net-next 05/12] net: dsa: existing DSA masters cannot join upper interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe46fd14-0635-a68d-ad5e-e9be06aa2a82@gmail.com>
Date:   Mon, 23 May 2022 10:58:45 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Marek Behún <kabel@...nel.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com,
        Colin Foster <colin.foster@...advantage.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [RFC PATCH net-next 05/12] net: dsa: existing DSA masters cannot
 join upper interfaces

On 5/23/22 03:42, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> All the traffic to/from a DSA master is supposed to be distributed among
> its DSA switch upper interfaces, so we should not allow other upper
> device kinds.
> 
> An exception to this is DSA_TAG_PROTO_NONE (switches with no DSA tags),
> and in that case it is actually expected to create e.g. VLAN interfaces
> on the master. But for those, netdev_uses_dsa(master) returns false, so
> the restriction doesn't apply.
> 
> The motivation for this change is to allow LAG interfaces of DSA masters
> to be DSA masters themselves. We want to restrict the user's degrees of
> freedom by 1: the LAG should already have all DSA masters as lowers, and
> while lower ports of the LAG can be removed, none can be added after the
> fact.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian