netdev - Re: [RFC PATCH net-next 02/12] net: dsa: walk through all changeupper notifier functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76977b89-23d8-be5e-dd74-1cefd8af3188@gmail.com>
Date:   Mon, 23 May 2022 11:11:01 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Marek Behún <kabel@...nel.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com,
        Colin Foster <colin.foster@...advantage.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [RFC PATCH net-next 02/12] net: dsa: walk through all changeupper
 notifier functions

On 5/23/22 03:42, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Traditionally, DSA has had a single netdev notifier handling function
> for each device type.
> 
> For the sake of code cleanliness, we would like to introduce more
> handling functions which do one thing, but the conditions for entering
> these functions start to overlap. Example: a handling function which
> tracks whether any bridges contain both DSA and non-DSA interfaces.
> Either this is placed before dsa_slave_changeupper(), case in which it
> will prevent that function from executing, or we place it after
> dsa_slave_changeupper(), case in which we will prevent it from
> executing. The other alternative is to ignore errors from the new
> handling function (not ideal).
> 
> To support this usage, we need to change the pattern. In the new model,
> we enter all notifier handling sub-functions, and exit with NOTIFY_DONE
> if there is nothing to do. This allows the sub-functions to be
> relatively free-form and independent from each other.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian