netdev - Re: [PATCH] samples: fix compile failure error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 12:39:41 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Ruijian Li <ruijian63@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, 798073189@...com
Subject: Re: [PATCH] samples: fix compile failure error

On Fri, May 20, 2022 at 5:09 PM Ruijian Li <ruijian63@...il.com> wrote:
>
> Because compile samples/bpf/test_lru_dist failure, I remove the
> declaration of the struct list_head.
>
> Signed-off-by: Ruijian Li <ruijian63@...il.com>
> ---
>  samples/bpf/test_lru_dist.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/samples/bpf/test_lru_dist.c b/samples/bpf/test_lru_dist.c
> index 75e877853596..dd7eb470653b 100644
> --- a/samples/bpf/test_lru_dist.c
> +++ b/samples/bpf/test_lru_dist.c
> @@ -33,10 +33,6 @@ static int nr_cpus;
>  static unsigned long long *dist_keys;
>  static unsigned int dist_key_counts;
>
> -struct list_head {
> -       struct list_head *next, *prev;
> -};
> -

this struct is used right there one line below, how removing it fixes
compilation issues? What was the error in the first place? Did you run
`make headers_install` before building samples/bpf? Please provide a
bit more information.

>  static inline void INIT_LIST_HEAD(struct list_head *list)
>  {
>         list->next = list;
> --
> 2.32.0
>