netdev - Re: [PATCH net-next] can: kvaser_usb: silence a GCC 12 -Warray-bounds warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220523121425.y5ca3ok5r2hxgh7j@pengutronix.de>
Date:   Mon, 23 May 2022 14:14:25 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, wg@...ndegger.com, linux-can@...r.kernel.org
Subject: Re: [PATCH net-next] can: kvaser_usb: silence a GCC 12
 -Warray-bounds warning

On 20.05.2022 12:46:59, Jakub Kicinski wrote:
> This driver does a lot of casting of smaller buffers to
> struct kvaser_cmd_ext, GCC 12 does not like that:
> 
> drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c:489:65: warning: array subscript ‘struct kvaser_cmd_ext[0]’ is partly outside array bounds of ‘unsigned char[32]’ [-Warray-bounds]
> drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c:489:23: note: in expansion of macro ‘le16_to_cpu’
>   489 |                 ret = le16_to_cpu(((struct kvaser_cmd_ext *)cmd)->len);
>       |                       ^~~~~~~~~~~
> 
> Temporarily silence this warning (move it to W=1 builds).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> Hi Marc, are you planning another -next PR? Can we take this
> directly?

Thanks, applied and I'll send a -next PR soonish.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)