netdev - Re: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220524141044.GA2666396@nvidia.com>
Date:   Tue, 24 May 2022 11:10:44 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     longli@...rosoft.com
Cc:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Leon Romanovsky <leon@...nel.org>,
        Ajay Sharma <sharmaajay@...rosoft.com>,
        linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure
 Network Adapter

On Tue, May 24, 2022 at 01:56:12AM -0700, longli@...uxonhyperv.com wrote:
> +struct mana_ib_qp {
> +	struct ib_qp ibqp;
> +
> +	// Send queue info
> +	struct ib_umem *sq_umem;
> +	int sqe;
> +	u64 sq_gdma_region;
> +	u64 sq_id;

There are still lots of coding style violations. Can you get someone
from Microsoft to help you make patches in the expected form?

Also, please don't repost until the next rc1.

Thanks,
Jason