netdev - RE: [PATCH net-next v3] drivers, ixgbe: export vf statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM8PR11MB562165BE16503138D1100255ABD79@DM8PR11MB5621.namprd11.prod.outlook.com>
Date:   Tue, 24 May 2022 15:52:26 +0000
From:   "Jankowski, Konrad0" <konrad0.jankowski@...el.com>
To:     Maximilian Heyne <mheyne@...zon.de>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v3] drivers, ixgbe: export vf statistics



> -----Original Message-----
> From: Maximilian Heyne <mheyne@...zon.de>
> Sent: Monday, May 9, 2022 1:04 PM
> Cc: Maximilian Heyne <mheyne@...zon.de>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; intel-wired-lan@...ts.osuosl.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH net-next v3] drivers, ixgbe: export vf statistics
> 
> This change retrieves network metrics for virtual functions from the device
> and exports them via the iproute2 interface.
> 
> The code for retrieving the statistics from the device is taken from the out-of-
> tree driver.  The feature was introduced with version 2.0.75.7, so the diff
> between this version and the previous version 2.0.72.4 was used to identify
> required changes. The export via ethtool is omitted in favor of using the
> standard ndo_get_vf_stats interface.
> 
> Per-VF statistics can now be printed, for instance, via
> 
>   ip --statistics link show dev eth0
> 
> Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
> ---
> v2: implemented the ndo_get_vf_stats callback
> v3: as per discussion, removed the ethtool changes
> 
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      | 34 ++++++++
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 86 +++++++++++++++++++
> drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  7 ++
>  3 files changed, 127 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> index 921a4d977d65..48444ab9e0b1 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> 

Tested-by: Konrad Jankowski <konrad0.jankowski@...el.com>