netdev - [PATCH v2 0/4] Implement vdpasim stop operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220524170610.2255608-1-eperezma@redhat.com>
Date:   Tue, 24 May 2022 19:06:06 +0200
From:   Eugenio Pérez <eperezma@...hat.com>
To:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Parav Pandit <parav@...dia.com>, Zhang Min <zhang.min9@....com.cn>,
        hanand@...inx.com, Zhu Lingshan <lingshan.zhu@...el.com>,
        tanuj.kamde@....com, gautam.dawar@....com,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Xie Yongji <xieyongji@...edance.com>, dinang@...inx.com,
        habetsm.xilinx@...il.com, Eli Cohen <elic@...dia.com>,
        pabloc@...inx.com, lvivier@...hat.com,
        Dan Carpenter <dan.carpenter@...cle.com>, lulu@...hat.com,
        Wu Zongyong <wuzongyong@...ux.alibaba.com>,
        eperezma@...hat.com, ecree.xilinx@...il.com,
        Piotr.Uminski@...el.com, martinpo@...inx.com,
        Stefano Garzarella <sgarzare@...hat.com>,
        Si-Wei Liu <si-wei.liu@...cle.com>,
        Longpeng <longpeng2@...wei.com>, martinh@...inx.com
Subject: [PATCH v2 0/4] Implement vdpasim stop operation

Implement stop operation for vdpa_sim devices, so vhost-vdpa will offer
that backend feature and userspace can effectively stop the device.

This is a must before get virtqueue indexes (base) for live migration,
since the device could modify them after userland gets them. There are
individual ways to perform that action for some devices
(VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no
way to perform it for any vhost device (and, in particular, vhost-vdpa).

After the return of ioctl with stop != 0, the device MUST finish any
pending operations like in flight requests. It must also preserve all
the necessary state (the virtqueue vring base plus the possible device
specific states) that is required for restoring in the future. The
device must not change its configuration after that point.

After the return of ioctl with stop == 0, the device can continue
processing buffers as long as typical conditions are met (vq is enabled,
DRIVER_OK status bit is enabled, etc).

In the future, we will provide features similar to VHOST_USER_GET_INFLIGHT_FD
so the device can save pending operations.

Comments are welcome.

v2:
* Replace raw _F_STOP with BIT_ULL(_F_STOP).
* Fix obtaining of stop ioctl arg (it was not obtained but written).
* Add stop to vdpa_sim_blk.

Eugenio Pérez (4):
  vdpa: Add stop operation
  vhost-vdpa: introduce STOP backend feature bit
  vhost-vdpa: uAPI to stop the device
  vdpa_sim: Implement stop vdpa op

 drivers/vdpa/vdpa_sim/vdpa_sim.c     | 21 +++++++++++++++++
 drivers/vdpa/vdpa_sim/vdpa_sim.h     |  1 +
 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c |  3 +++
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c |  3 +++
 drivers/vhost/vdpa.c                 | 34 +++++++++++++++++++++++++++-
 include/linux/vdpa.h                 |  6 +++++
 include/uapi/linux/vhost.h           |  3 +++
 include/uapi/linux/vhost_types.h     |  2 ++
 8 files changed, 72 insertions(+), 1 deletion(-)

-- 
2.27.0