netdev - RE: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR21MB3263ABDFC1425CD3DC39F05DCED79@PH7PR21MB3263.namprd21.prod.outlook.com>
Date:   Tue, 24 May 2022 18:41:25 +0000
From:   Long Li <longli@...rosoft.com>
To:     Jason Gunthorpe <jgg@...dia.com>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Leon Romanovsky <leon@...nel.org>,
        Ajay Sharma <sharmaajay@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure
 Network Adapter

> Subject: Re: [Patch v2 12/12] RDMA/mana_ib: Add a driver for Microsoft
> Azure Network Adapter
> 
> On Tue, May 24, 2022 at 01:56:12AM -0700, longli@...uxonhyperv.com wrote:
> > +struct mana_ib_qp {
> > +	struct ib_qp ibqp;
> > +
> > +	// Send queue info
> > +	struct ib_umem *sq_umem;
> > +	int sqe;
> > +	u64 sq_gdma_region;
> > +	u64 sq_id;
> 
> There are still lots of coding style violations. Can you get someone from
> Microsoft to help you make patches in the expected form?

I'm sorry, I will fix all the style issues. clang-format and checkpatch.pl didn't catch those.

Long

> 
> Also, please don't repost until the next rc1.
> 
> Thanks,
> Jason