netdev - Re: packet stuck in qdisc : patch proposal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <317a3e67-0956-e9c2-0406-9349844ca612@gmail.com>
Date:   Tue, 24 May 2022 13:17:10 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Vincent Ray <vray@...rayinc.com>,
        linyunsheng <linyunsheng@...wei.com>
Cc:     davem <davem@...emloft.net>,
        方国炬 <guoju.fgj@...baba-inc.com>,
        kuba <kuba@...nel.org>, netdev <netdev@...r.kernel.org>,
        Samuel Jones <sjones@...rayinc.com>,
        vladimir oltean <vladimir.oltean@....com>,
        Guoju Fang <gjfang@...ux.alibaba.com>,
        Remy Gauguey <rgauguey@...rayinc.com>, will <will@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: packet stuck in qdisc : patch proposal


On 5/24/22 10:00, Vincent Ray wrote:
> All,
>
> I confirm Eric's patch works well too, and it's better and clearer than mine.
> So I think we should go for it, and the one from Guoju in addition.
>
> @Eric : I see you are one of the networking maintainers, so I have a few questions for you :
>
> a) are you going to take care of these patches directly yourself, or is there something Guoju or I should do to promote them ?

I think this is totally fine you take ownership of the patch, please 
send a formal V2.

Please double check what patchwork had to say about your V1 :


https://patchwork.kernel.org/project/netdevbpf/patch/1684598287.15044793.1653314052575.JavaMail.zimbra@kalray.eu/


And make sure to address the relevant points

The most important one is the lack of 'Signed-off-by:' tag, of course.


> b) Can we expect to see them land in the mainline soon ?

If your v2 submission is correct, it can be merged this week ;)


>
> c) Will they be backported to previous versions of the kernel ? Which ones ?

You simply can include a proper Fixes: tag, so that stable teams can 
backport

the patch to all affected kernel versions.



>
> Thanks a lot, best,

Thanks a lot for working on this long standing issue.