netdev - Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <237b793b-ab52-4ff8-a2a5-44923f79da40@nvidia.com>
Date:   Mon, 23 May 2022 17:10:07 -0700
From:   Roopa Prabhu <roopa@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>,
        netdev@...r.kernel.org, outreachy@...ts.linux.dev,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: vxlan: Fix kernel coding style


On 5/20/22 17:40, Jakub Kicinski wrote:
> On Thu, 19 May 2022 22:06:53 -0700 Roopa Prabhu wrote:
>>> @@ -1138,7 +1138,7 @@ static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan,
>>>    	if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] ||
>>>    	    tb[NDA_PORT])) {
>>>    			NL_SET_ERR_MSG(extack,
>>> -						  "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
>>> +					"DST, VNI, ifindex and port are mutually exclusive with NH_ID");
>> it looks still off by a space.
>>
>>>    			return -EINVAL;
>>>    		}
>>
>> this closing brace should line up with the if
> Let me just fix this myself when applying... There were 3 separate
> postings of v2, and they weren't even identical :(


thanks Jakub,


Alaa, when you accidentally send the same patch multiple times, you can 
reply on the list and leave a note to the maintainer on which ones to 
ignore (lets add this to the outreachy kernel patch submission 
instructions if not already there)