netdev - RE: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9690c0a1e444dcdbab8a9c1eb0f98df@realtek.com>
Date:   Tue, 24 May 2022 00:41:12 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "colin.king@...el.com" <colin.king@...el.com>
Subject: RE: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12


> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, May 23, 2022 11:57 PM
> To: Ping-Ke Shih <pkshih@...ltek.com>
> Cc: kvalo@...nel.org; johannes@...solutions.net; netdev@...r.kernel.org; linux-wireless@...r.kernel.org;
> keescook@...omium.org; colin.king@...el.com
> Subject: Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12
> 
> On Mon, 23 May 2022 02:35:32 +0000 Ping-Ke Shih wrote:
> > This is a typo since initial commit. Correct it by
> > -			     value[0] != NULL)
> > +			     value[0][0] != 0)
> >
> > So, NACK this patch.
> 
> Too, late, the patches were already applied, sorry. Please post a fixup.

I have sent a patch to correct it: 
https://lore.kernel.org/linux-wireless/20220524003750.3989-1-pkshih@realtek.com/T/#u

Please take it into net-next tree.

Thank you
Ping-Ke