netdev - Re: [PATCH] ipv6/addrconf: fix timing bug in tempaddr regen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5Ym4gm49mkMUKzyPqKT8vt3M67NZB-zoep3bu+VB3FbuVzCQ@mail.gmail.com>
Date:   Wed, 25 May 2022 14:07:17 -0600
From:   Sam Edwards <cfsworks@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Linux Network Development Mailing List 
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6/addrconf: fix timing bug in tempaddr regen

Bah, I've had to resend this since it went out as HTML yesterday.
Sorry about the double mailing everyone!

On Tue, May 24, 2022 at 3:24 AM Paolo Abeni <pabeni@...hat.com> wrote:
> I looks like with this change the tmp addresses will never hit the
> DEPRECATED branch ?!?

The DEPRECATED branch becomes reachable again once this line is hit:
ifp->regen_count++;
...because it causes this condition in the elseif to evaluate false:
!ifp->regen_count