netdev - RE: [PATCH] net/mlx5: Fix memory leak in mlx5_sf_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR12MB548184F122D980C9AFD72C68DCD99@PH0PR12MB5481.namprd12.prod.outlook.com>
Date:   Thu, 26 May 2022 12:39:49 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        Jianglei Nie <niejianglei2021@....com>,
        Saeed Mahameed <saeedm@...dia.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>, Vu Pham <vuhuong@...dia.com>,
        Shay Drory <shayd@...dia.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net/mlx5: Fix memory leak in mlx5_sf_dev_add()



> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Thursday, May 26, 2022 7:14 AM
> 
> On Thu, 2022-05-26 at 16:44 +0800, Jianglei Nie wrote:
> > The variable id is allocated by mlx5_adev_idx_alloc(). When some error
> > happens, the id should be freed by mlx5_adev_idx_free().But when
> > auxiliary_device_add() and xa_insert() fail, the id is not freed,which
> > will lead to a potential memory leak.
> >
> > We can fix it by calling mlx5_sf_dev_add() when auxiliary_device_add()
> > and xa_insert() fail.
> >
> > Signed-off-by: Jianglei Nie <niejianglei2021@....com>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
> > index 7da012ff0d41..9f222061a1c0 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
> > @@ -125,13 +125,16 @@ static void mlx5_sf_dev_add(struct
> mlx5_core_dev
> > *dev, u16 sf_index, u16 fn_id,
> >
> >  	err = auxiliary_device_add(&sf_dev->adev);
> >  	if (err) {
> > +		mlx5_adev_idx_free(id);
> >  		put_device(&sf_dev->adev.dev);
> 
> This looks not correct. put_device() -> mlx5_sf_dev_release() -> should
> already take care of that.
> 
Right. As Paolo explained, current code doesn’t have the cited bug.

> >  		goto add_err;
> >  	}
> >
> >  	err = xa_insert(&table->devices, sf_index, sf_dev, GFP_KERNEL);
> > -	if (err)
> > +	if (err) {
> > +		mlx5_adev_idx_free(id);
> >  		goto xa_err;
> > +	}
> >  	return;
> >
> >  xa_err: