netdev - Re: [PATCH] dt-bindings: net/dsa: Add spi-peripheral-props.yaml references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220526220450.GB315754-robh@kernel.org>
Date:   Thu, 26 May 2022 17:04:50 -0500
From:   Rob Herring <robh@...nel.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Marek Vasut <marex@...x.de>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net/dsa: Add spi-peripheral-props.yaml
 references

On Thu, May 26, 2022 at 03:32:16AM +0300, Vladimir Oltean wrote:
> On Wed, May 25, 2022 at 03:57:50PM -0500, Rob Herring wrote:
> > SPI peripheral device bindings need to reference spi-peripheral-props.yaml
> > in order to use various SPI controller specific properties. Otherwise,
> > the unevaluatedProperties check will reject any controller specific
> > properties.
> > 
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 1 +
> >  Documentation/devicetree/bindings/net/dsa/realtek.yaml       | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > index 184152087b60..6bbd8145b6c1 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >  
> >  allOf:
> >    - $ref: dsa.yaml#
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> >  
> >  properties:
> >    # See Documentation/devicetree/bindings/net/dsa/dsa.yaml for a list of additional
> > diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > index 99ee4b5b9346..4f99aff029dc 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> > @@ -108,6 +108,7 @@ if:
> >      - reg
> >  
> >  then:
> > +  $ref: /schemas/spi/spi-peripheral-props.yaml#
> >    not:
> >      required:
> >        - mdc-gpios
> > -- 
> > 2.34.1
> > 
> 
> Also needed by nxp,sja1105.yaml and the following from brcm,b53.yaml:
> 	brcm,bcm5325
> 	brcm,bcm5365
> 	brcm,bcm5395
> 	brcm,bcm5397
> 	brcm,bcm5398
> 	brcm,bcm53115
> 	brcm,bcm53125
> 	brcm,bcm53128

Okay. Looks like you missed bcm5389?

Rob