netdev - Re: [PATCH net-next 1/1] net: phy: dp83867: retrigger SGMII AN when link change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 May 2022 16:18:39 +0800
From:   Tan Tee Min <tee.min.tan@...ux.intel.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Voon Wei Feng <weifeng.voon@...el.com>,
        Sit Michael Wei Hong <michael.wei.hong.sit@...el.com>,
        Ling Pei Lee <pei.lee.ling@...el.com>,
        Looi Hong Aun <hong.aun.looi@...el.com>,
        Tan Tee Min <tee.min.tan@...el.com>
Subject: Re: [PATCH net-next 1/1] net: phy: dp83867: retrigger SGMII AN when
 link change

On Wed, May 25, 2022 at 09:56:29PM -0700, Jakub Kicinski wrote:
> On Thu, 26 May 2022 09:37:14 +0800 Tan Tee Min wrote:
> > As suggested by TI, implemented a SW solution here to retrigger SGMII
> > Auto-Neg whenever there is a link change.
> 
> Thanks, sounds like this bug has always been in the driver so we should
> add:
> 
> Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")
> 
> Is that right? Getting a workaround like this into stable eventually
> seems like a good idea so Fixes tag will help.

Thanks for the quick response.

Yes, you are right.
Let me add the Fixes tag and Cc <stable@...r.kernel.org> in v2 patch.

Thanks,
Tee Min