netdev - Re: [PATCH v2 net-next] selftests: forwarding: add Per-Stream Filtering and Policing test for Ocelot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220526005021.l5motcuqdotkqngm@skbuf>
Date:   Thu, 26 May 2022 00:50:22 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ferenc Fejes <ferenc.fejes@...csson.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Gerhard Engleder <gerhard@...leder-embedded.com>,
        "Y.B. Lu" <yangbo.lu@....com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Richard Cochran <richardcochran@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        Yannick Vignon <yannick.vignon@....com>,
        Rui Sousa <rui.sousa@....com>, Jiri Pirko <jiri@...dia.com>,
        Ido Schimmel <idosch@...dia.com>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "shuah@...nel.org" <shuah@...nel.org>
Subject: Re: [PATCH v2 net-next] selftests: forwarding: add Per-Stream
 Filtering and Policing test for Ocelot

On Fri, May 06, 2022 at 12:24:37PM +0000, Ferenc Fejes wrote:
> Hi Vladimir!
> 
> On 2022. 05. 06. 14:01, Vladimir Oltean wrote:
> > Hi Ferenc,
> >
> > On Fri, May 06, 2022 at 07:49:40AM +0000, Ferenc Fejes wrote:
> > This is correct. I have been testing only with the offloaded tc-gate
> > action so I did not notice that the software does not act upon the ipv.
> > Your proposal sounds straightforward enough. Care to send a bug fix patch?
> 
> Unfortunately I cant, our company policy does not allow direct 
> open-source contributions :-(
> 
> However I would be more than happy if you can fix it.

That's too bad.

I have a patch which I am still testing, but you've managed to captivate
my attention for saying that you are testing 802.1Qch with a software
implementation of tc-gate.

Do you have a use case for this? What cycle times are you targeting?
How are you ensuring that you are deterministically meeting the deadlines?
Do you also have a software tc-taprio on the egress device or is that
at least offloaded?

I'm asking these questions because the peristaltic shaper is primarily
intended to be used on hardware switches. The patch I'm preparing
includes changes to struct sk_buff. I just want to know how well I'll be
able to sell these changes to maintainers strongly opposing the growth
of this structure for an exceedingly small niche :)