netdev - Re: [PATCH v2] ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to avoid adding weak function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 May 2022 16:36:41 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org
Subject: Re: [PATCH v2] ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to avoid adding
 weak function

On Fri, 27 May 2022 12:04:14 +0200
Ingo Molnar <mingo@...nel.org> wrote:

> For those which implement objtool, it certainly should: as we parse through 
> each object file during the build, generating kallsyms data structures is 
> relatively straightforward.
> 
> Objtool availability is a big gating condition though. :-/
> 
> [ ... and still Acked-by on -v4 too. ]

I just sent out a v5 and removed your Acked-by because the changes to v5
are non-trivial like the previous changes in the other versions were.

The big difference was that I needed place holders for the invalid
functions in the available_filter_functions file, as I forgot that
libtracefs uses the line number of these functions as a way to enable them
in the set_ftrace_filter and set_ftrace_notrace files. Removing them made
the indexing not in sync, and broke trace-cmd.

I also added a work queue at boot up to run through all the records and
mark any of the ones that fail the kallsyms check as DISABLED.

If you want, feel free to review and ack that change too.

  https://lore.kernel.org/all/20220527163205.421c7828@gandalf.local.home/

I need to add a selftest to test the indexing code as well. The only reason
I found it was that I was writing my presentation for Embedded Recipes and
was using it as an example. And when the filtering wasn't working, I had to
figure out why.

-- Steve