netdev - Re: [PATCH net] bonding: NS target should accept link local address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 May 2022 16:28:01 -0700
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Hangbin Liu <liuhangbin@...il.com>
cc:     netdev@...r.kernel.org, Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, Li Liang <liali@...hat.com>
Subject: Re: [PATCH net] bonding: NS target should accept link local address

Hangbin Liu <liuhangbin@...il.com> wrote:

>When setting bond NS target, we use bond_is_ip6_target_ok() to check
>if the address valid. The link local address was wrongly rejected in
>bond_changelink(), as most time the user just set the ARP/NS target to
>gateway, while the IPv6 gateway is always a link local address when user
>set up interface via SLAAC.
>
>So remove the link local addr check when setting bond NS target.
>
>Fixes: 129e3c1bab24 ("bonding: add new option ns_ip6_target")
>Reported-by: Li Liang <liali@...hat.com>
>Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>


>---
> drivers/net/bonding/bond_netlink.c | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
>index f427fa1737c7..6f404f9c34e3 100644
>--- a/drivers/net/bonding/bond_netlink.c
>+++ b/drivers/net/bonding/bond_netlink.c
>@@ -290,11 +290,6 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
> 
> 			addr6 = nla_get_in6_addr(attr);
> 
>-			if (ipv6_addr_type(&addr6) & IPV6_ADDR_LINKLOCAL) {
>-				NL_SET_ERR_MSG(extack, "Invalid IPv6 addr6");
>-				return -EINVAL;
>-			}
>-
> 			bond_opt_initextra(&newval, &addr6, sizeof(addr6));
> 			err = __bond_opt_set(bond, BOND_OPT_NS_TARGETS,
> 					     &newval);
>-- 
>2.35.1
>