netdev - Re: [PATCH v5] ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to avoid adding weak function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 May 2022 23:18:56 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org
Subject: Re: [PATCH v5] ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to avoid adding
 weak function

On Fri, 27 May 2022 16:32:05 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> @@ -4003,7 +4128,11 @@ ftrace_match_record(struct dyn_ftrace *rec, struct ftrace_glob *func_g,
>  	char str[KSYM_SYMBOL_LEN];
>  	char *modname;
>  
> -	kallsyms_lookup(rec->ip, NULL, NULL, &modname, str);
> +	if (lookup_ip(rec->ip, &modname, str)) {
> +		/* This should only happen when a rec is disabled */
> +		WARN_ON_ONCE(!(rec->flags & FTRACE_FL_DISABLED));

It appears that some of the start up tests can call this before the
workqueue sets it to DISABLED, so we need to not WARN_ON() here. :-/

-- Steve


> +		return 0;
> +	}
>