netdev - Re: [PATCH net] net/mlx5: Don't use already freed action pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220528052809.raf6bjndaxs2fvxk@sx1>
Date:   Fri, 27 May 2022 22:28:09 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Leon Romanovsky <leonro@...dia.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Eric Dumazet <edumazet@...gle.com>, linux-rdma@...r.kernel.org,
        Maor Gottlieb <maorg@...dia.com>,
        Mark Bloch <markb@...dia.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net] net/mlx5: Don't use already freed action pointer

On 24 May 15:59, Leon Romanovsky wrote:
>From: Leon Romanovsky <leonro@...dia.com>
>
>The call to mlx5dr_action_destroy() releases "action" memory. That
>pointer is set to miss_action later and generates the following smatch
>error:
>
> drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c:53 set_miss_action()
> warn: 'action' was already freed.
>
>Make sure that the pointer is always valid by setting NULL after destroy.
>
>Fixes: 6a48faeeca10 ("net/mlx5: Add direct rule fs_cmd implementation")
>Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>Signed-off-by: Leon Romanovsky <leonro@...dia.com>

Applied to net-mlx5. I am still working on other critical fixes in my
net queue, will submit all at once next week so we can make it to rc1.

Thanks,
Saeed