netdev - RE: [PATCH net-next] dt-bindings: net: xilinx: document xilinx emaclite driver binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR02MB856087686FE497BDCE413E89C7DC9@SA1PR02MB8560.namprd02.prod.outlook.com>
Date:   Tue, 31 May 2022 18:19:35 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "harini.katakam@....com" <harini.katakam@....com>,
        "michal.simek@....com" <michal.simek@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "git@....com" <git@....com>
Subject: RE: [PATCH net-next] dt-bindings: net: xilinx: document xilinx
 emaclite driver binding

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, May 31, 2022 12:40 AM
> To: Radhey Shyam Pandey <radheys@...inx.com>; Radhey Shyam Pandey
> <radhey.shyam.pandey@....com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> harini.katakam@....com; michal.simek@....com
> Cc: netdev@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; git@....com
> Subject: Re: [PATCH net-next] dt-bindings: net: xilinx: document xilinx emaclite
> driver binding
> 
> On 30/05/2022 15:21, Radhey Shyam Pandey wrote:
> >>
> >>> +        local-mac-address = [00 0a 35 00 00 00];
> >>
> >> Each device should get it's own MAC address, right? I understand you
> >> leave it for bootloader, then just fill it with 0.
> >
> > The emaclite driver uses of_get_ethdev_address() to get mac from DT.
> > i.e  'local-mac-address' if present in DT it will be read and this MAC
> > address is programmed in the MAC core. So I think it's ok to have a
> > user defined mac-address (instead of 0s) here in DT example?
> 
> And you want to program the same MAC address in every device in the world?
> How would that work?

I agree, for most of practical usecases mac address will be set by bootloader[1].
But just thinking for usecases where uboot can't read from non-volatile memory
user are still provided with option to set local-mac-address in DT and let linux
also configures it? Also see this in couple of other networking driver examples. 

cdns,macb.yaml:  local-mac-address: true
cdns,macb.yaml:            local-mac-address = [3a 0e 03 04 05 06];
brcm,systemport.yaml:        local-mac-address = [ 00 11 22 33 44 55 ];

In emaclite yaml - as it an example I will set it mac-address to 0 to align 
with common usecase.  local-mac-address = [00 00 00 00 00 00]

[1]: https://support.xilinx.com/s/article/53476

> 
> 
> 
> Best regards,
> Krzysztof