netdev - Re: [PATCH net 1/2] net: add debug info to __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSf_27LFtjFF8bQpnoNzohD_Qm0HLEptetbP-aaxBoohjg@mail.gmail.com>
Date:   Tue, 31 May 2022 15:31:20 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net 1/2] net: add debug info to __skb_pull()

On Tue, May 31, 2022 at 2:59 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> While analyzing yet another syzbot report, I found the following
> patch very useful. It allows to better understand what went wrong.
>
> This debug info is only enabled if CONFIG_DEBUG_NET=y,
> which is the case for syzbot builds.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

The skb_dump output (including packet headers) on these bugs will make
root causing these failures a lot easier in the future. Thanks!