netdev - Re: [PATCH net-next] selftests: net: fib_rule_tests: add support to run individual tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <928114e2-05c4-3cfe-7a9e-05ae89f18807@nvidia.com>
Date:   Tue, 31 May 2022 15:43:51 -0700
From:   Roopa Prabhu <roopa@...dia.com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>,
        netdev@...r.kernel.org
Cc:     outreachy@...ts.linux.dev, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: fib_rule_tests: add support to
 run individual tests


On 5/30/22 11:12, Alaa Mohamed wrote:
> add -t option to run individual tests in the test with -t option
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> ---

Alaa, I suggest you send a v2 with a fixes tag for this. This actually 
completes commit "816cda9ae531" which went in incomplete.

For examples of fixes tag, look for "Fixes" in git log. change the patch 
title to convey the fix.

rest looks good.



>   tools/testing/selftests/net/fib_rule_tests.sh | 23 +++++++++++++++++++
>   1 file changed, 23 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index bbe3b379927a..c245476fa29d 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -303,6 +303,29 @@ run_fibrule_tests()
>   	log_section "IPv6 fib rule"
>   	fib_rule6_test
>   }
> +################################################################################
> +# usage
> +
> +usage()
> +{
> +	cat <<EOF
> +usage: ${0##*/} OPTS
> +
> +        -t <test>   Test(s) to run (default: all)
> +                    (options: $TESTS)
> +EOF
> +}
> +
> +################################################################################
> +# main
> +
> +while getopts ":t:h" opt; do
> +	case $opt in
> +		t) TESTS=$OPTARG;;
> +		h) usage; exit 0;;
> +		*) usage; exit 1;;
> +	esac
> +done
>   
>   if [ "$(id -u)" -ne 0 ];then
>   	echo "SKIP: Need root privileges"