netdev - Re: [PATCH] selftests net: fix bpf build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c462ffc-f2c0-f542-4e61-251571da8c22@iogearbox.net>
Date:   Wed, 1 Jun 2022 01:01:13 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Lina Wang <lina.wang@...iatek.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Maciej enczykowski <maze@...gle.com>, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, lkp@...el.com, rong.a.chen@...el.com,
        kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH] selftests net: fix bpf build error

On 5/30/22 8:21 AM, Lina Wang wrote:
> bpf_helpers.h has been moved to tools/lib/bpf since 5.10, so add more
> incliding path.
> 
> Fixes: edae34a3ed92 ("selftests net: add UDP GRO fraglist + bpf self-tests")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Signed-off-by: Lina Wang <lina.wang@...iatek.com>
> ---
>   tools/testing/selftests/net/bpf/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/bpf/Makefile b/tools/testing/selftests/net/bpf/Makefile
> index f91bf14bbee7..070251986dbe 100644
> --- a/tools/testing/selftests/net/bpf/Makefile
> +++ b/tools/testing/selftests/net/bpf/Makefile
> @@ -2,6 +2,7 @@
>   
>   CLANG ?= clang
>   CCINCLUDE += -I../../bpf
> +CCINCLUDE += -I../../../../lib
>   CCINCLUDE += -I../../../../../usr/include/
>   
>   TEST_CUSTOM_PROGS = $(OUTPUT)/bpf/nat6to4.o
> 

 From building the selftest in general, I'm getting:

clang -O2 -target bpf -c bpf/nat6to4.c -I../../bpf -I../../../../lib -I../../../../../usr/include/ -o /root/daniel/bpf/tools/testing/selftests/net/bpf/nat6to4.o
In file included from bpf/nat6to4.c:27:
In file included from /usr/include/linux/bpf.h:11:
/usr/include/linux/types.h:5:10: fatal error: 'asm/types.h' file not found
#include <asm/types.h>
          ^~~~~~~~~~~~~
1 error generated.

Could we reuse the build infra from tools/testing/selftests/bpf/ for nat6to4.c?