netdev - Re: [PATCH v2] socket: Use __u8 instead of u8 in uapi socket.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e77647a5c3c538ae6beb668083e1b6090dccb62.camel@redhat.com>
Date:   Tue, 31 May 2022 11:24:46 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     David Laight <David.Laight@...LAB.COM>,
        'Tobias Klauser' <tklauser@...tanz.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Akhmat Karakotov <hmukos@...dex-team.ru>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] socket: Use __u8 instead of u8 in uapi socket.h

On Mon, 2022-05-30 at 08:20 +0000, David Laight wrote:
> From: Tobias Klauser
> > Sent: 30 May 2022 09:15
> > 
> > Use the uapi variant of the u8 type.
> > 
> > Fixes: 26859240e4ee ("txhash: Add socket option to control TX hash rethink behavior")
> > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> > ---
> > v2: add missing <linux/types.h> include as reported by kernel test robot
> > 
> >  include/uapi/linux/socket.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/uapi/linux/socket.h b/include/uapi/linux/socket.h
> > index 51d6bb2f6765..62a32040ad4f 100644
> > --- a/include/uapi/linux/socket.h
> > +++ b/include/uapi/linux/socket.h
> > @@ -2,6 +2,8 @@
> >  #ifndef _UAPI_LINUX_SOCKET_H
> >  #define _UAPI_LINUX_SOCKET_H
> > 
> > +#include <linux/types.h>
> > +
> >  /*
> >   * Desired design of maximum size and alignment (see RFC2553)
> >   */
> > @@ -31,7 +33,7 @@ struct __kernel_sockaddr_storage {
> > 
> >  #define SOCK_BUF_LOCK_MASK (SOCK_SNDBUF_LOCK | SOCK_RCVBUF_LOCK)
> > 
> > -#define SOCK_TXREHASH_DEFAULT	((u8)-1)
> > +#define SOCK_TXREHASH_DEFAULT	((__u8)-1)
> 
> I can't help feeling that 255u (or 0xffu) would be a better
> way to describe that value.

Even plain '255' would do. Additionally, any of the above will avoid
the additional header dependency.

Thanks,

Paolo